[ 
https://issues.apache.org/jira/browse/HIVE-16034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886079#comment-15886079
 ] 

Jesus Camacho Rodriguez commented on HIVE-16034:
------------------------------------------------

[~ashutoshc], that is a good idea, I will add that check and throw that 
Exception.

[~bslim], AFAIK, this will only be reproducible at runtime, thus we would need 
integration tests. Or I could refactor the code and extract the switch on 
_type_ to a new method, then add a negative test for that method; however, that 
seems an overkill since we would be only testing a switch statement. If you 
have any other idea for testing it, let me know and I can add it.

> Hive/Druid integration: Fix type inference for Decimal DruidOutputFormat
> ------------------------------------------------------------------------
>
>                 Key: HIVE-16034
>                 URL: https://issues.apache.org/jira/browse/HIVE-16034
>             Project: Hive
>          Issue Type: Bug
>          Components: Druid integration
>    Affects Versions: 2.2.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>         Attachments: HIVE-16034.patch
>
>
> We are extracting the type name by String, which might cause issues, e.g., 
> for Decimal, where type includes precision and scale. Instead, we should 
> check the PrimitiveCategory enum.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to