[
https://issues.apache.org/jira/browse/HIVE-16034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886309#comment-15886309
]
slim bouguerra commented on HIVE-16034:
---------------------------------------
[~jcamachorodriguez] seems like the contract of {code}
getHiveRecordWriter{code} is to parse the {code} tableProperties{code} object
and build stuff like aggregators.
Thought would be to mock {code} tableProperties{code} and make sure that we
get the right aggregators/dimension specs or that we get an exception for the
case of timestamp. If you think it is an overkill that's ok we can skip it.
Overall i am +1
> Hive/Druid integration: Fix type inference for Decimal DruidOutputFormat
> ------------------------------------------------------------------------
>
> Key: HIVE-16034
> URL: https://issues.apache.org/jira/browse/HIVE-16034
> Project: Hive
> Issue Type: Bug
> Components: Druid integration
> Affects Versions: 2.2.0
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Attachments: HIVE-16034.01.patch, HIVE-16034.patch
>
>
> We are extracting the type name by String, which might cause issues, e.g.,
> for Decimal, where type includes precision and scale. Instead, we should
> check the PrimitiveCategory enum.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
