[
https://issues.apache.org/jira/browse/HIVE-16174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904924#comment-15904924
]
Hive QA commented on HIVE-16174:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12857297/HIVE-16174.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 10332 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver
(batchId=232)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4065/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4065/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4065/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12857297 - PreCommit-HIVE-Build
> Update MetricsConstant.WAITING_COMPILE_OPS metric when we aquire lock failed
> in Driver
> --------------------------------------------------------------------------------------
>
> Key: HIVE-16174
> URL: https://issues.apache.org/jira/browse/HIVE-16174
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
> Affects Versions: 2.2.0
> Reporter: yunfei liu
> Assignee: yunfei liu
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: HIVE-16174.1.patch
>
>
> In Driver#compileInternal method (as the code snippet below ), we need to
> update MetricsConstant.WAITING_COMPILE_OPS metric correctly before return if
> lock can not be acquired.
> {code}
> Metrics metrics = MetricsFactory.getInstance();
> if (metrics != null) {
> metrics.incrementCounter(MetricsConstant.WAITING_COMPILE_OPS, 1);
> }
> final ReentrantLock compileLock = tryAcquireCompileLock(isParallelEnabled,
> command);
> if (compileLock == null) {
> return ErrorMsg.COMPILE_LOCK_TIMED_OUT.getErrorCode();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
