[
https://issues.apache.org/jira/browse/HIVE-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947597#comment-15947597
]
Vihang Karajgaonkar commented on HIVE-16297:
--------------------------------------------
{{HiveConfUtil.dumpConfig}} uses a StringBuilder to dump the config values
while {{Configuration.dumpConfiguration}} dumps the configs in a JSON format.
Also it adds some msgs like {{"sb.append("Values omitted for security reason if
present: ").append(hiddenSet).append("\n");
"}} I didn't feel it would be a good idea to like duplicate the JSON conversion
logic in Hive when Hadoop Configuration object already provides utility method
for that. There is a another method called {{HiveConfUtil.stripConfigurations}}
which replaces the hidden configs values with empty Strings. This I thought is
little confusing because the user doesn't know if the config value is really an
empty string or it was stripped for security reasons. So thought of adding a
new util method which uses {{***REDACTED***}} string so that it is clear that
it was indeed redacted for security reasons. Let me know if I should remove
{{HiveConfUtil.redactConfigurations}} and use
{{HiveConfUtil.stripConfigurations}} instead.
> Improving hive logging configuration variables
> ----------------------------------------------
>
> Key: HIVE-16297
> URL: https://issues.apache.org/jira/browse/HIVE-16297
> Project: Hive
> Issue Type: Improvement
> Reporter: Vihang Karajgaonkar
> Assignee: Vihang Karajgaonkar
> Attachments: HIVE-16297.01.patch
>
>
> There are a few places in the source-code where we use
> {{Configuration.dumpConfiguration()}}. We should preprocess the configuration
> properties before dumping it in the logs.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
