[ 
https://issues.apache.org/jira/browse/HIVE-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948603#comment-15948603
 ] 

Peter Vary commented on HIVE-16297:
-----------------------------------

Hi [~vihangk1],

One solution could be:
- Add a new parameter to stripConfigurations - replaceString: the string which 
should used instead of the hidden ones. Maybe we should rename the method too, 
to match the new function
- Use the dumpConfiguration in {{FileSinkOperator}}, {{RemoteHiveSparkClient}}, 
since the functionality seems the same to me.
- Use this stripConfigurations method with "***REDACTED***" in case of the 
{{ConfServlet}}

Another thing that occurred to me after taking a second look on the patch:
- Is it planned, that we hide the configuration values in the {{ConfServlet}} 
only in json format, and not in xml format?

Anyway, thanks for catching this issue, I thought I already removed all of the 
unstripped configuration dumps!

Thanks,
Peter

> Improving hive logging configuration variables
> ----------------------------------------------
>
>                 Key: HIVE-16297
>                 URL: https://issues.apache.org/jira/browse/HIVE-16297
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>         Attachments: HIVE-16297.01.patch
>
>
> There are a few places in the source-code where we use 
> {{Configuration.dumpConfiguration()}}. We should preprocess the configuration 
> properties before dumping it in the logs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to