[jira] [Comment Edited] (HIVE-16430) Add log to show the cancelled query id when cancelOperation is called.

[zhihai xu (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HIVE-16430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967135#comment-15967135
 ] 

zhihai xu edited comment on HIVE-16430 at 4/13/17 4:55 AM:
-----------------------------------------------------------

Thanks for the review [~xuefuz]! good suggestion, I add log when successfully 
cancelled a query in the new patch HIVE-16430.001.patch. Looks like for 
cancellation failure, currently it is already logged at the following code:
{code}
    try {
      cliService.cancelOperation(new OperationHandle(req.getOperationHandle()));
      resp.setStatus(OK_STATUS);
    } catch (Exception e) {
      LOG.warn("Error cancelling operation: ", e);
      resp.setStatus(HiveSQLException.toTStatus(e));
    }
{code}
So I don't need to add the failure log.


was (Author: zxu):
Thanks for the review [~xuefuz]! good suggestion, I add log when successfully 
cancelled a query. Looks like for cancellation failure, currently it is already 
logged at the following code:
{code}
    try {
      cliService.cancelOperation(new OperationHandle(req.getOperationHandle()));
      resp.setStatus(OK_STATUS);
    } catch (Exception e) {
      LOG.warn("Error cancelling operation: ", e);
      resp.setStatus(HiveSQLException.toTStatus(e));
    }
{code}
So I don't need to add the failure log.

> Add log to show the cancelled query id when cancelOperation is called.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-16430
>                 URL: https://issues.apache.org/jira/browse/HIVE-16430
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Trivial
>         Attachments: HIVE-16430.000.patch, HIVE-16430.001.patch
>
>
> Add log to show the cancelled query id when cancelOperation is called.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)