[
https://issues.apache.org/jira/browse/HIVE-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967153#comment-15967153
]
Hive QA commented on HIVE-16433:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12863175/HIVE-16433.000.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 10571 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[columnstats_part_coltype]
(batchId=155)
org.apache.hive.jdbc.TestJdbcDriver2.testSelectExecAsync2 (batchId=221)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4669/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4669/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4669/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12863175 - PreCommit-HIVE-Build
> Not nullify rj to avoid NPE due to race condition in ExecDriver.
> ----------------------------------------------------------------
>
> Key: HIVE-16433
> URL: https://issues.apache.org/jira/browse/HIVE-16433
> Project: Hive
> Issue Type: Bug
> Reporter: zhihai xu
> Assignee: zhihai xu
> Priority: Minor
> Attachments: HIVE-16433.000.patch
>
>
> Not nullify rj to avoid NPE due to race condition in ExecDriver. currently
> {{rj}} is set to null in ExecDriver.shutdown which is called from other
> thread for query cancellation. It can happen at any time. There is a
> potential race condition, the rj is still accessed after shutdown is called.
> For example: if the following code is executed right after
> ExecDriver.shutdown is called.
> {code}
> this.jobID = rj.getJobID();
> updateStatusInQueryDisplay();
> returnVal = jobExecHelper.progress(rj, jc, ctx);
> {code}
> Currently the purpose of nullifying rj is mainly to make sure
> {{rj.killJob()}} is only called once.
> I will add a flag jobKilled to make sure {{rj.killJob()}} will be only called
> once.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
