[ 
https://issues.apache.org/jira/browse/HIVE-16469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975063#comment-15975063
 ] 

Hive QA commented on HIVE-16469:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12864030/HIVE-16469.02.patch

{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 42 failed/errored test(s), 10583 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[smb_mapjoin_1] 
(batchId=234)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_analyze] 
(batchId=22)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_windowing2] 
(batchId=10)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
 (batchId=143)
org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testAmbiguousSingleFieldGroupInList
 (batchId=255)
org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testAvroPrimitiveInList
 (batchId=255)
org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testAvroSingleFieldGroupInList
 (batchId=255)
org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testHiveRequiredGroupInList
 (batchId=255)
org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testMultiFieldGroupInList
 (batchId=255)
org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testNewOptionalGroupInList
 (batchId=255)
org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testNewRequiredGroupInList
 (batchId=255)
org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testThriftPrimitiveInList
 (batchId=255)
org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testThriftSingleFieldGroupInList
 (batchId=255)
org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testUnannotatedListOfGroups
 (batchId=255)
org.apache.hadoop.hive.ql.io.parquet.TestArrayCompatibility.testUnannotatedListOfPrimitives
 (batchId=255)
org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testDoubleMapWithStructValue
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testMapWithComplexKey 
(batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testNestedMap 
(batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testStringMapOfOptionalArray
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testStringMapOfOptionalIntArray
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testStringMapOptionalPrimitive
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestMapStructures.testStringMapRequiredPrimitive
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestParquetRowGroupFilter.testRowGroupFilterTakeEffect
 (batchId=255)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.decimalRead 
(batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.structReadSomeNull
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testBinaryRead 
(batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testBooleanRead 
(batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testDoubleRead 
(batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testFloatRead 
(batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testIntRead 
(batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testLongRead 
(batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testNestedStructRead
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testStructRead 
(batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.decimalRead
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.structReadSomeNull
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testBinaryRead
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testDoubleRead
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testFloatRead
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testIntRead
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testLongRead
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testNestedStructRead
 (batchId=254)
org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testStructRead
 (batchId=254)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4760/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4760/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4760/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 42 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12864030 - PreCommit-HIVE-Build

> Parquet timestamp table property is not always taken into account
> -----------------------------------------------------------------
>
>                 Key: HIVE-16469
>                 URL: https://issues.apache.org/jira/browse/HIVE-16469
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Barna Zsombor Klara
>            Assignee: Barna Zsombor Klara
>         Attachments: HIVE-16469.01.patch, HIVE-16469.02.patch
>
>
> The parquet timestamp timezone property is currently copied over into the 
> JobConf in the FetchOperator, but this may be too late for some execution 
> paths.
> We should:
> 1 - copy the property over earlier
> 2 - set the default value on the JobConf if no property is set, and fail in 
> the ParquetRecordReader if the property is missing from the JobConf
> We should add extra validations for the cases when:
> - the property was not set by accident on the JobConf (unexpected execution 
> path)
> - an incorrect/invalid timezone id is being set on the table



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to