[
https://issues.apache.org/jira/browse/HIVE-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055609#comment-16055609
]
Hive QA commented on HIVE-16920:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12873634/HIVE-16920.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 14 failed/errored test(s), 10833 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic]
(batchId=140)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[columnstats_part_coltype]
(batchId=157)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_smb_main]
(batchId=149)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
(batchId=232)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query16]
(batchId=232)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23]
(batchId=232)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query94]
(batchId=232)
org.apache.hadoop.hive.ql.io.orc.TestNewInputOutputFormat.testNewInputFormatPruning
(batchId=260)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcrossInstances.testBootstrapFunctionReplication
(batchId=216)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcrossInstances.testCreateFunctionIncrementalReplication
(batchId=216)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcrossInstances.testCreateFunctionWithFunctionBinaryJarsOnHDFS
(batchId=216)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionRegistrationWithCustomSchema
(batchId=177)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSpecRegistrationWithCustomSchema
(batchId=177)
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation
(batchId=177)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5689/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5689/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5689/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 14 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12873634 - PreCommit-HIVE-Build
> remove useless uri.getScheme() from EximUtil
> --------------------------------------------
>
> Key: HIVE-16920
> URL: https://issues.apache.org/jira/browse/HIVE-16920
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 3.0.0
> Reporter: Fei Hui
> Assignee: Fei Hui
> Attachments: HIVE-16920.patch
>
>
> {code:title=EximUtil.java|borderStyle=solid}
> static URI getValidatedURI(HiveConf conf, String dcPath) throws
> SemanticException {
> try {
> boolean testMode = conf.getBoolVar(HiveConf.ConfVars.HIVETESTMODE);
> URI uri = new Path(dcPath).toUri();
> String scheme = uri.getScheme();
> String authority = uri.getAuthority();
> String path = uri.getPath();
> FileSystem fs = FileSystem.get(uri, conf);
> LOG.info("Path before norm :" + path);
> // generate absolute path relative to home directory
> if (!path.startsWith("/")) {
> if (testMode) {
> path = (new Path(System.getProperty("test.tmp.dir"),
> path)).toUri().getPath();
> } else {
> path =
> (new Path(new Path("/user/" + System.getProperty("user.name")),
> path)).toUri()
> .getPath();
> }
> }
> // Get scheme from FileSystem
> scheme = fs.getScheme();
> ...
> }
> {code}
> We found that {{String scheme = uri.getScheme();}} is useless, we can remove
> it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
