[
https://issues.apache.org/jira/browse/HIVE-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056653#comment-16056653
]
Ferdinand Xu commented on HIVE-16920:
-------------------------------------
+1 LGTM
> remove useless uri.getScheme() from EximUtil
> --------------------------------------------
>
> Key: HIVE-16920
> URL: https://issues.apache.org/jira/browse/HIVE-16920
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 3.0.0
> Reporter: Fei Hui
> Assignee: Fei Hui
> Attachments: HIVE-16920.patch
>
>
> {code:title=EximUtil.java|borderStyle=solid}
> static URI getValidatedURI(HiveConf conf, String dcPath) throws
> SemanticException {
> try {
> boolean testMode = conf.getBoolVar(HiveConf.ConfVars.HIVETESTMODE);
> URI uri = new Path(dcPath).toUri();
> String scheme = uri.getScheme();
> String authority = uri.getAuthority();
> String path = uri.getPath();
> FileSystem fs = FileSystem.get(uri, conf);
> LOG.info("Path before norm :" + path);
> // generate absolute path relative to home directory
> if (!path.startsWith("/")) {
> if (testMode) {
> path = (new Path(System.getProperty("test.tmp.dir"),
> path)).toUri().getPath();
> } else {
> path =
> (new Path(new Path("/user/" + System.getProperty("user.name")),
> path)).toUri()
> .getPath();
> }
> }
> // Get scheme from FileSystem
> scheme = fs.getScheme();
> ...
> }
> {code}
> We found that {{String scheme = uri.getScheme();}} is useless, we can remove
> it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
