[ 
https://issues.apache.org/jira/browse/HIVE-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105495#comment-16105495
 ] 

Vihang Karajgaonkar commented on HIVE-17167:
--------------------------------------------

Hi [~alangates] Thanks for the patch. Quick question regarding the patch: Looks 
like it is possible to store two different values for MetaConf.Confvars.varname 
and MetaConf. Confvars.hivename. For example: user could do the following:

{noformat}
MetaConf metaConf = newMetaConf();
metaConf.set("metastore.myconfig.name", "X");
metaConf.set("hive.metastore.myconfig.name", "Y");
{noformat}

In this case will MetaConf.get(metaConf, "metastore.myconfig.name") and 
MetaConf.get(metaConf, "hive.metastore.myconfig.name") return two different 
values? Shouldn't the set call check if a corresponding equivalent key is set 
as well and if yes, overwrite it as well?


> Create metastore specific configuration tool
> --------------------------------------------
>
>                 Key: HIVE-17167
>                 URL: https://issues.apache.org/jira/browse/HIVE-17167
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Metastore
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: HIVE-17167.patch
>
>
> As part of making the metastore a separately releasable module we need 
> configuration tools that are specific to that module.  It cannot use or 
> extend HiveConf as that is in hive common.  But it must take a HiveConf 
> object and be able to operate on it.
> The best way to achieve this is using Hadoop's Configuration object (which 
> HiveConf extends) together with enums and static methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to