[
https://issues.apache.org/jira/browse/HIVE-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106210#comment-16106210
]
Vihang Karajgaonkar commented on HIVE-17167:
--------------------------------------------
Hi [~alangates], left some comments on the github review. I am a bit concerned
that this might become error-prone when there are different values for the
metastore key and hive variant of that key. Either we should enforce the order
of lookup in the get() method or not allow conflicting values of different
variants of the keys. I can easily see the end-users setting some configuration
in metastore-site.xml but code is looking up the hive variant of the key and in
the end the configuration change is not really getting enabled in the code.
Instead of controlling how not to allow users doing
{{conf.set("metastore.myconfig.name", "x")}} via reviews, I think it would be
good to enforce this in code somehow.
> Create metastore specific configuration tool
> --------------------------------------------
>
> Key: HIVE-17167
> URL: https://issues.apache.org/jira/browse/HIVE-17167
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore
> Reporter: Alan Gates
> Assignee: Alan Gates
> Attachments: HIVE-17167.patch
>
>
> As part of making the metastore a separately releasable module we need
> configuration tools that are specific to that module. It cannot use or
> extend HiveConf as that is in hive common. But it must take a HiveConf
> object and be able to operate on it.
> The best way to achieve this is using Hadoop's Configuration object (which
> HiveConf extends) together with enums and static methods.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
