[
https://issues.apache.org/jira/browse/HIVE-17314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128670#comment-16128670
]
ASF GitHub Bot commented on HIVE-17314:
---------------------------------------
GitHub user dosoft opened a pull request:
https://github.com/apache/hive/pull/234
HIVE-17314: Removed obsolete code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dosoft/hive HIVE-17314
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hive/pull/234.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #234
----
commit ff68fb77fd221e669d3c5b8a3312da1ced2939bf
Author: Oleg Danilov <[email protected]>
Date: 2017-08-16T11:53:16Z
HIVE-17314: Removed obsolete code
----
> LazySimpleSerializeWrite.writeString() contains if with an empty body
> ---------------------------------------------------------------------
>
> Key: HIVE-17314
> URL: https://issues.apache.org/jira/browse/HIVE-17314
> Project: Hive
> Issue Type: Bug
> Reporter: Oleg Danilov
> Priority: Minor
>
> Looking at the LazySimpleSerializeWrite.java I found odd 'if':
> Lines 234-235:
> {code:java}
> if (v.equals(nullSequenceBytes)) {
> }
> {code}
> Seems like either something is missed there or this 'if' could be dropped out.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
