Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/87
  
    There are several design options to consider:
     1) move `-iter` and `-mini-batch` functionalities to LeanerBaseUDTF
       => but, it cannot be used for MulticlassOnlineClassifier.. :-(
     2) make BinaryOnlineClassfierUDTF/RegressionBaseUDTF the subclass of 
GeneraLearnerBaseUDTF
       => regression bug may occur ..
     3) make Abstract IterativeLearnerBaseUDTF as the subclass of 
LearnerBaseUDTF
       => too complex object hierarchy (not good design)
     4) implement `-iter` and `-mini-batch` functionalities in 
BinaryOnlineClassfierUDTF/RegressionBaseUDTF
       => duplicate code, hard for maintenance
     5) Mixin iteration supoprt
       => callback is needed and not a pattern for mixin
     6) generalize `-iter` support for MulticlassOnelineClassifierUDTF
       => not straightforward design
    
    Also, `-mini_batch` design should be well revised for online perceptron 
variants.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to