Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/87
It takes so long to reflect this kind of changes by review comments. Find
commit logs for my points for review.
https://github.com/myui/incubator-hivemall/commit/ac062f2f5f8e0eb9ad093d4b92f478d791fcbbf4
is bug fix of ConversionState usage (cumulative loss is not reset at the
beginning of 2nd iteration).
https://github.com/myui/incubator-hivemall/commit/b999196913874361b3e9e12c65418675a3070c23
avoided `-tol` and fixed to use existing ConversionState.
https://github.com/myui/incubator-hivemall/commit/94e16366d54b6fa4e58a7e78d9db16aea83eee3f
revised variable scope in ConversionState.
https://github.com/myui/incubator-hivemall/commit/94e16366d54b6fa4e58a7e78d9db16aea83eee3f
Fixed a bug in readFrom.
https://github.com/myui/incubator-hivemall/commit/65233ff69d653df432d88eb4ecbc9031a6de60c5
numSteps should be long to avoid overflow.
I guess `-tol` used in your PR was too small to find existing bugs in
optimizer (not bugs in this PR).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
