sramazzina commented on code in PR #5647:
URL: https://github.com/apache/hop/pull/5647#discussion_r2468238900
##########
plugins/transforms/metainject/src/main/java/org/apache/hop/pipeline/transforms/metainject/MetaInject.java:
##########
@@ -472,7 +486,21 @@ private void newInjectionConstants(
if (injector.hasProperty(targetTransformMeta,
target.getAttributeKey())) {
// target transform has specified key
String value = variables.resolve(source.getField());
- injector.setProperty(targetTransformMeta,
target.getAttributeKey(), null, value);
+ if
(targetTransformMeta.getClass().getSimpleName().equals("FormulaMeta")
Review Comment:
Hi @mattcasters it's a long story and the solution is not the optimal and
the cleanest because is a workaround. I agree with your thoughts trust me. I
tried to describe the wild (let me say) approach I followed in my code. The
idea is that only when the injected transform is Formula, I inject the datatype
id (1, 2, 3 etc) and not the datatype value (Integer, String, Number etc)
written by the user in the Metadata Injection dialog. I hope you understood
what I mean. I agree this workaround is stupid and weird but the optimal change
that is having a Formula transform that writes the datatype values and not the
ids breaks backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
