jdkinaxis opened a new pull request, #6240: URL: https://github.com/apache/hop/pull/6240
Fixes #6239 ------------------------ Rather than relying on the plugins to always do if(isRowLevel()) prior to calling logRowLevel, let's make the filtering of log messages based on visibility occur before a LogMessage is instantiated. As seen in the bug, the performance drops 100x (Both running at the same log level "Basic") if just a single call to logRowLevel is made in a plugin without the if clause. Performance when a single if IsRowLevel check is missed in the textfileinput plugin <img width="562" height="64" alt="image" src="https://github.com/user-attachments/assets/da024d86-8e0e-4933-bd96-4dc73c616e17"; /> Performance with the safety net added in LogChannel class <img width="663" height="65" alt="image" src="https://github.com/user-attachments/assets/6866b501-a63c-4533-9f88-31d929fa5667"; /> Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
