mattcasters opened a new pull request, #7509:
URL: https://github.com/apache/hop/pull/7509

   ## What
   
   Adds `hop-gui-nolog.bat` so Hop GUI can start on Windows without leaving a 
console window open (uses `javaw` + `start`).
   
   `hop-gui.bat` is unchanged in behavior and still keeps the console open for 
log output.
   
   ## Why
   
   Fixes #7142. Some users want a clean GUI launch (desktop shortcut, no 
console); others still need the console for debugging and log output.
   
   ## How
   
   - New `hop-gui-nolog.bat`: resolves `HOP_JAVA_HOME` / `JAVA_HOME` to 
`javaw`, then launches with `start "" "%_HOP_JAVA%" ...`
   - Path is stored without embedded quotes and quoted at the call site, with 
an empty `start` title, so paths with spaces (e.g. `Program Files`) work
   - Cross-links in `hop-gui.bat` help and `README.txt`
   - Minor fix: add missing `:End` label in `hop-gui.bat`
   
   ## Test plan
   
   - [x] Tested on Windows 11 Pro with Microsoft OpenJDK 25
   - [x] `hop-gui-nolog.bat` starts Hop GUI and console closes
   - [ ] `hop-gui.bat` still starts Hop GUI with console logging
   - [ ] Paths with spaces in `JAVA_HOME` / `HOP_JAVA_HOME` work with 
`hop-gui-nolog.bat`
   - [ ] `hop-gui-nolog.bat help` and `hop-gui.bat help` show the expected 
cross-references
   
   @nadment please review when you have a chance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to