mattcasters commented on PR #7550: URL: https://github.com/apache/hop/pull/7550#issuecomment-5016177624
Hey @nadment — I took a look at where this was stuck and opened a small follow-up with the three gaps fixed: **[#7576](https://github.com/apache/hop/pull/7576)** (branch `help-7550-content-editor` on my fork) ### What was breaking CI `IContentEditorWidget.getLanguage()` was added but RAP’s Monaco/fallback widgets didn’t implement it → `hop-ui-rap` compile failure. ### Markdown preview + GuiRegistry Once preview moved onto `ContentEditor-Toolbar`, the toolbar registers the **editor widget**, not the file handler. `BaseGuiWidgets` only resolved static listeners with an **exact** parameter class match, so `previewMarkdown(IContentEditorWidget)` never matched `ContentEditorWidget`. Fix: resolve static listeners with an **assignable** parameter type (interface/facade), and keep preview as: ```java public static void previewMarkdown(IContentEditorWidget editorWidget) ``` ### hop-web toolbar RAP now builds the shared `ContentEditor-Toolbar` so plugin actions (preview) can show in web as well. Full Monaco cut/copy/paste remote ops are still thin/no-op where the client doesn’t expose them yet. Feel free to cherry-pick/merge from that branch into `7549` if you want to keep a single PR — happy either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
