mattcasters commented on PR #7550: URL: https://github.com/apache/hop/pull/7550#issuecomment-5016423779
### Follow-up on Hop Web content editor / Markdown preview Further work is on **[#7576](https://github.com/apache/hop/pull/7576)** (`help-7550-content-editor`), stacked on your #7550 changes: 1. **Tomcat 404** — `hop-ui-rcp` was on the Hop Web classpath (copied from client `lib/core`). Scanning the new `ContentEditorWidget` `@GuiPlugin` failed with `NoClassDefFoundError: VerifyKeyListener`. Dockerfile / `run-hop-web-local.sh` now strip `hop-ui-rcp` from the web image. 2. **Toolbar above text files on web** — edit actions (`@GuiToolbarElement`) moved to shared `ui` class `ContentEditorActions` (static handlers on `IContentEditorWidget`). No new annotation type; same pattern as your Preview button. Desktop keeps context menu + keyboard shortcuts on RCP `ContentEditorWidget`. 3. **Markdown Preview click on web** — `file://` temp HTML is not visible to the client browser. On RAP we open `ShowBrowserDialog` with the rendered HTML; desktop still uses temp file + system browser. Feel free to cherry-pick / merge from that branch into `7549`, or we can keep helping via #7576 — whichever you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
