zanarellidev opened a new pull request, #8094: URL: https://github.com/apache/hop/pull/8094
<!-- Thank you for contributing to Apache Hop! Please read the following before submitting your pull request. --> ### Description Fixes #4935. When running Shell actions with arguments (e.g. API keys, database credentials, passwords, or tokens), Hop currently logs the raw execution command with all arguments visible in the execution log at `BASIC` log level. This creates a security risk / credential exposure in log sinks, execution history, and UI logs. This PR adds support for **Hidden Arguments** in the Shell Action: 1. **POJO & Metadata**: Added static inner class `ActionShell.ShellArgument` with `value` and `hidden` properties. 2. **Backward Compatibility**: Fully backward compatible with legacy pipeline/workflow XML definitions (via legacy string parsing in `loadXml`). 3. **Secure Log Masking**: Replaces hidden arguments with `***` in execution log outputs (`logBasic`), while preserving raw unmasked argument values for the operating system process execution via `ProcessBuilder`. 4. **GUI / Dialog**: Added a `Hidden (Y/N)` CCombo column in `ActionShellDialog` for easy GUI configuration. 5. **Tests**: Added unit tests in `WorkflowActionShellLoadSaveTest.java` covering `ShellArgument` serialization and hidden flag behavior. All 8 tests in the module pass cleanly. ### Testing - [x] Unit tests pass via `mvn test` - [x] Spotless code format applied ------------------------ Thank you for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
