zanarellidev commented on PR #8094:
URL: https://github.com/apache/hop/pull/8094#issuecomment-5431005715
Hi @mattcasters, thank you for the review!
I have updated the PR according to your feedback:
1. **Removed `loadXml()`** from `ActionShell.java`.
2. **Implemented `ILegacyXml`**:
- `ShellArgument` implements `ILegacyXml` to parse values from previous
Hop XMLs (`<arguments><argument>value</argument></arguments>`).
- `ActionShell` implements `ILegacyXml` to handle older numbered tags
(`<argument0>val0</argument0>`).
3. **Simplified the diff**: Reverted duplicate command-building branches in
`executeShell`, isolating log masking into a clean `buildLogCommand` helper.
4. **Backward Compatibility Tests**: Added comprehensive tests in
`WorkflowActionShellLoadSaveTest` verifying:
- Backward compatibility loading old numbered arguments (`<argument0>`,
`<argument1>`).
- Backward compatibility loading previous
`<arguments><argument>val</argument></arguments>` format.
- Serialization & round-trip with the new structure (`<value>`,
`<hidden>`).
- Command masking in execution logs.
All tests and spotless checks pass cleanly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
