sramazzina opened a new pull request, #8146:
URL: https://github.com/apache/hop/pull/8146
- The editor shell was created without any size or title, so the platform
sized every new instance from its cascaded origin to the screen edge and each
reopening came up smaller: give the shell a title and an explicit default size,
and let BaseTransformDialog.setSize() restore the geometry saved on close (no
minimum, so a smaller size the user picked is kept).
- ok()/cancel() dropped the shell without recording its geometry, so a
manual resize was lost at every close: store the WindowProperty before
disposing.
- rightSash weights {10, 80} left the expression editor 11% of the height,
no longer enough since the text composite gained a toolbar: use {40, 60}.
- SWTBot test covering that a reopening restores the size the user chose.
Fixes #8139
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks
pass. A more thorough check will be performed on your pull request
automatically.
- [ ] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
