sramazzina commented on PR #8146:
URL: https://github.com/apache/hop/pull/8146#issuecomment-5454970703
The `ui-tests` job failed on the SWTBot test added by this PR, not on the
fix itself.
The failure is `TimeoutException: Timed out waiting for Shell {Formula
Expression E...} to get activated`. SWTBot finds the shell — its title is set
in the constructor — but the shell never opens: the last construction step
visible in the log is `no GUI toolbar items found for root:
TextComposite-Toolbar`, i.e. the `StyledTextComp`, and the next thing the
constructor does is create the `Browser` used for the function description
pane. On Linux that widget needs WebKitGTK, and the workflow installs only
`xvfb` and `libgtk-3-0`, so it throws while the dialog is being built. The
exception is swallowed because the SWTBot timeout is reported first. This test
is the first UI test in the repository that instantiates an SWT `Browser`,
which is why the gap had not surfaced before.
The follow-up commit makes the test probe the `Browser` widget up front and
skip when it is unavailable, and raises the SWTBot timeout for this test from
the 5 s default, since building the editor (function library plus browser
start-up) is slow on a cold runner. The test runs and passes on a desktop with
WebKitGTK present.
That keeps CI green, but it also means the test is skipped rather than
executed on CI, and the same will apply to any future UI test that touches a
`Browser`-based dialog (the help and browser dialogs in `hop-ui`, for
instance). @hansva — as you look after the CI jobs: adding
`libwebkit2gtk-4.1-0` to the apt install in
`.github/workflows/pr_build_code.yml` would be enough to make these run on CI.
It is a change to the shared workflow rather than to this transform, so I have
left it out of this PR and leave the decision to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
