mattcasters opened a new pull request, #8634: URL: https://github.com/apache/hop/pull/8634
Add Sequence reported a missing database connection when it was generating the sequence with a counter. The connection field is only used when "Use DB to get sequence" is selected. The default, a pipeline counter, leaves that field empty. The pipeline check treated every connection field as required, so it warned "No database connection is assigned". Verify also tried to load the empty name and reported that it could not connect to the database. A metadata object can now say that a connection field is unused for the current settings. The connection checker skips that field. Add Sequence does this unless a database sequence is selected. Verify and Get SQL no longer open a connection in the counter case. Selecting a database sequence and leaving the connection empty still reports the missing connection. fixes #8561 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
