mattcasters opened a new pull request, #8688: URL: https://github.com/apache/hop/pull/8688
Duplicating a pipeline or workflow run configuration that lives in a parent project wrote the new JSON file into that same parent folder. The copy then showed up in every project that inherits the parent, including the parent itself and its other children. A run configuration created from scratch is saved in the active project's metadata folder instead. Duplicate in the metadata perspective now asks which metadata location should receive the copy when the original is not stored in the active project. The active project is selected by default, which keeps the copy local the way a new object is. You can still choose the original location, and cancelling the dialog does not create a copy. Objects that already belong to the active project are duplicated there without a prompt. The same command is used for every metadata type, so this is not limited to run configurations. MultiMetadataLegacyKeysTest and JsonMetadataLegacyKeysTest cover where the copy is written, including an explicit parent or child provider. Command: `./mvnw -pl core -am test -Dtest=MultiMetadataLegacyKeysTest,JsonMetadataLegacyKeysTest -Dsurefire.failIfNoSpecifiedTests=false` (48 tests, all passed). The dialog change was compiled with `tools/with-isolated-display.sh ./mvnw -pl ui -am compile -DskipTests`. The selection dialog itself was not opened in a GUI session. fixes #4248 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
