mattcasters opened a new pull request, #8694: URL: https://github.com/apache/hop/pull/8694
Environment configuration files could only be added one path at a time, in the environment dialog and in hop-conf. A folder of JSON files had to be picked file by file. The configuration files tab now takes a file or a directory, an inclusion regular expression, an exclusion regular expression, and an option to include subfolders. Add resolves that selection and appends each matching file to the list, so Edit still opens one file. Select can add several files at once. A path under a project or environment variable is rewritten the same way as a normal browse. hop-conf accepts `--environment-config-file-directory`, `--environment-config-file-wildcard`, `--environment-config-file-exclude-wildcard`, and `--environment-config-include-subfolders`. They can be combined with `--environment-config-files`. When any of them is set, that selection replaces the environment's configuration file list. The wildcard is a regular expression matched against the file name (`.*\.json`), not a shell glob (`*.json`). A required flag is not stored: the discussion on the issue settled on expanding matches into the existing file list. Docker variables were left out, as the reporter suggested a separate ticket for those. `./mvnw -pl plugins/misc/projects -am test -Dtest=EnvironmentConfigFileSelectorTest,ManageEnvironmentsOptionPluginTest -Dsurefire.failIfNoSpecifiedTests=false` passed (11 tests). The same tests were run again after an assertion fix. The GUI was not opened, and `mvn clean install apache-rat:check` was not run. fixes #4881 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
