bamaer commented on PR #8795: URL: https://github.com/apache/hop/pull/8795#issuecomment-6053885190
Built the branch and ran the `hop-engines-spark` tests: all pass. The new assertion in `SparkLakeTableIcebergPathTest` fails against main's `SparkLakeTableSupport`, so it covers the bug. I also checked Iceberg PATH maintenance, which the tests don't cover: in a fresh session, `REWRITE_MANIFESTS` and `EXPIRE_SNAPSHOTS` hit the table at its path. Looks good to me. Optional leftovers: the old Javadoc block above `ensureIcebergPathCatalog(SparkSession, String)`, the `hop_iceberg` mention in the `readIcebergPath` error message, and `lakehouse.adoc:295`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
