bamaer commented on PR #8799:
URL: https://github.com/apache/hop/pull/8799#issuecomment-6066781831
Code reviewed, not built or run. No blockers.
**Should fix**
1. **Spaces are forced in tab-indented content.** Tab now always inserts
spaces, and Monaco gets `insertSpaces: true, detectIndentation: false`
(`monaco-editor.js:338-340`). Before this change, Monaco followed the file's
own indentation. A Makefile, a TSV file, or a tab-indented Python script opened
in the content editor now gets spaces on the next indented line. That breaks
Makefile recipes and gives Python a `TabError`. In SWT fields there is no
longer any way to type a literal tab.
*Fix:* in Monaco, set only `tabSize` and keep its own indentation
detection. In `TextIndent`, either indent with a tab when the line already
starts with one, or let `HOP_TEXT_TAB_SIZE=0` mean "insert a tab".
2. **Hop Web traps keyboard focus in multi-line fields.** In a browser
`textarea`, Tab used to move to the next field. `text-indent.js:359` now
catches every plain Tab, and Ctrl+Tab belongs to the browser, so a
keyboard-only user can't leave the field.
*Fix:* let Tab through as normal focus movement right after Esc, as
Monaco (Ctrl+M) and GitHub do. Mention it in `shortcuts.adoc`.
Minor: `TextIndent.tabSize()` puts environment variables above `-D` system
properties. `HopResolvedSettings.resolveString()` already defines the Hop order
(hop-config, then env, then `-D`), so it could use that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
