mattcasters opened a new pull request, #8881:
URL: https://github.com/apache/hop/pull/8881

   The samples integration test runs every pipeline and workflow copied into 
the samples project. Build 2342 failed `samples.0001-run-samples` on the 
GraphRAG samples added in #8858.
   
   `graphrag-ask-hybrid.hpl` tries to open Apache AGE connection `demo-age`. 
The samples environment does not set `AGE_HOSTNAME`, `AGE_PORT`, or 
`AGE_DATABASE`, so the JDBC URL cannot be parsed and the pipeline aborts. 
`graphrag-ask.hpl` then fails the same way on Neo4j connection `demo-neo4j`. 
The runner stops at the first error, so `graphrag-index.hpl`, 
`graphrag-index-hybrid.hpl`, and `graphrag-index.hwf` were not reached. They 
use the same graph connections and the `ollama-embeddings` and `ollama-local` 
AI providers.
   
   Those five files are now in the samples runner ignore list, with the other 
samples that need a service this suite does not start. GraphRAG keeps its own 
integration tests under the AGE, FalkorDB, Memgraph, and Neo4j plugins.
   
   fixes #8880
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to