bamaer commented on PR #8900: URL: https://github.com/apache/hop/pull/8900#issuecomment-6152665848
Thanks @hansva, LGTM. No blockers. What I checked: - **Build:** full build of the branch, no errors. - **Combination lookup dialog:** an SWTBot check on desktop. With "Hash field in stream" set, the dialog opens with the value still there after the background field lookup, and there's no "Invalid thread access". `CCombo.setItems` keeps the text in both SWT and RAP, so the `asyncExec` doesn't clear it. - **Hop Web:** `HopWebRunTest` and `HopWebDialogTest`, which use the new `ExecutionResultsPanel`, pass against an image built from this branch. - **Transform dialog sweep:** 207 of 276 cases pass, which is every transform in a default build, Combination lookup included. The other 69 are Beam and `-Pfull` plugins that weren't in my local image, so I didn't verify those entries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
