hansva commented on code in PR #8900:
URL: https://github.com/apache/hop/pull/8900#discussion_r4268132105
##########
plugins/transforms/combinationlookup/src/main/java/org/apache/hop/pipeline/transforms/combinationlookup/CombinationLookupDialog.java:
##########
@@ -659,8 +659,17 @@ protected void setComboBoxes() {
//
String[] fieldNames = ConstUi.sortFieldNames(inputFields);
ciKey[1].setComboValues(fieldNames);
+ // Called from the background thread that reads the input fields: touch
the widget on the UI
+ // thread only, or SWT throws "Invalid thread access".
if (wHashFieldInStream != null && !wHashFieldInStream.isDisposed()) {
- wHashFieldInStream.setItems(fieldNames);
+ wHashFieldInStream
+ .getDisplay()
+ .asyncExec(
+ () -> {
+ if (!wHashFieldInStream.isDisposed()) {
+ wHashFieldInStream.setItems(fieldNames);
Review Comment:
wHashFieldInStream is a ComboVar, which wraps a CCombo (ComboVar.java:119).
What is said about Combo.setItems clearing the text on GTK is true for the
native Combo, but not for this widget.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
