bamaer commented on PR #8996: URL: https://github.com/apache/hop/pull/8996#issuecomment-6249403198
Thanks @spannm, nice simplification of the pom. Checked locally against main: - The plugin zip ships jackcess-5.2.0, hsqldb-2.7.4 and ucanaccess-5.2.0, all in `lib/jdbc`; the dependency tree pulls in nothing else. - Jackcess moves from `lib/core` to `lib/jdbc`. Access Output uses Jackcess directly, but it has `isIncludeJdbcDrivers = true`, so it still finds it. On an assembled client, Access Output writes an .accdb and Table Input reads it back through the UCanAccess connection, with the same result as main. - Module unit tests pass. No blockers from my side. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
