Adalennis opened a new pull request, #9024: URL: https://github.com/apache/hop/pull/9024
Second batch: a Result section on the File exists, Create file, Delete files, Shell, Move files and Zip file pages, in the format of the first batch (#9000). Every row comes from a test run with hop-run on current main (47 cases). While at it, existing text that was wrong: - Shell, Return status: it said a return value of 1 means success and 0 failure; it's the other way around. - Delete files, Include Subfolders: it deletes the matching files in subfolders, never the folders. - Labels aligned with Hop Gui: File name (File exists), Specify logfile and Copy previous results to args (Shell, Delete files), Add files to result files name (Move files). Two notes describe current behaviour that may be worth a code fix: Move files' "errors lesser than" condition and its Fail option counting an existing file twice, and Delete files ignoring an invalid regular expression. - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
