Adalennis commented on PR #9024: URL: https://github.com/apache/hop/pull/9024#issuecomment-6284523772
Thanks @bamaer. Changes added: - Zip file: fixed all three. A source that can't be moved after zipping leaves the action true with the zip in the result files (now a NOTE; only a failed delete makes it false). With Include sub-folders on, no match is false and creates no zip. An empty source or Get arguments from previous passes on the previous result, even when every row zipped. While testing I also corrected the Result files row: a zip that was created stays in the result files even when the action ends up false. - Delete files and Move files: the Copy previous results to args row now says result rows, with the fields. - Shell: added the no-rows case, and the Windows cmd.exe behaviour (from the code; I couldn't test on Windows). - Move files, "counts as two errors": I kept it. An existing destination file with Fail gave 2 errors both with a single-file entry and with a folder entry (folder src/ with a.txt, dst/a.txt existing: errors=2). Line 1043 sets entryStatus for a subfolder in the listing; for a file inside the folder, moveOneFile returns moveFile's false and the folder loop calls updateErrors() again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
