bamaer commented on PR #9025:
URL: https://github.com/apache/hop/pull/9025#issuecomment-6274883873
@Adalennis thanks, I checked each change against the code on main (hop-conf
`-sv`/`-dv`, the Azure `-aza`/`-azk`/`-aze` options and config fields, the Set
Variables default/empty-field/multi-row behaviour, the xref targets). All
correct. Code and source checked; I didn't render the docs locally.
**Should fix (small)**
- `variables.adoc:179`: "unless a property with the same name was already
set with `-D`" is right for the Java property. Inside pipelines and workflows,
though, the value from the System variables tab still wins over `-D`, because
`Variables.initializeFrom` adds the hop-config variables after the system
properties. Suggest adding: "Inside pipelines and workflows,
`${MY_SYSTEM_VARIABLE}` still resolves to the value from this tab."
LGTM otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
