bamaer commented on PR #9102: URL: https://github.com/apache/hop/pull/9102#issuecomment-6540193440
Thanks @SAY-5, this looks good to me. I built the git plugin from this branch and ran `UIGitTest` and `HopDiffTest`. All pass. Without the `tw.next()` check, the new test fails with the `MissingObjectException` from #8929. I also checked a file in a subfolder that a commit deletes: `open()` returns null for it, so the visual diff shows that side as empty. I didn't try it in the GUI. Optional, could also be a follow-up: the commit perspective's visual diff compares the working tree with HEAD. For a pipeline that's deleted but not yet committed, `open(file, WORKINGTREE)` still throws `Unable to find working tree file …`. Returning null there when the file doesn't exist would cover that case too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
