mattcasters opened a new pull request, #9204: URL: https://github.com/apache/hop/pull/9204
Several transform dialogs cleared a field combo and then asked the previous transform for its fields. `removeAll` also clears the text. When that lookup threw, the configured name was never written back, and OK could store an empty field. JSON Input is the case in #5953. The same sequence is in the dialogs in this pull request, including JSON Normalize Input. The lookup now runs first. The combo is cleared only after it returns, and the saved name is written back on the success path as before. A failed lookup leaves the configured name in place. `ComboItems` replaces a combo's items and writes the previous text back, including a name that is not in the new list. `BaseTransformDialog.getFieldsFromPrevious` uses it. `ComboItemsTest` covers that restore (3 tests, 0 failures). JSON Input itself is #9203, so this branch does not edit `JsonInputDialog`. addresses #5953 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
