mattcasters commented on PR #9204: URL: https://github.com/apache/hop/pull/9204#issuecomment-6576208313
@bamaer thanks for the review. PGP Encrypt Stream was still calling removeAll() on the stream field before the lookup. Both combos are filled only after getPrevTransformFields returns. Get XML Data no longer adds or selects <EMPTY> in the catch block, so a failed lookup leaves the configured field. Language Model Chat's GeneralSettingsComposite had the same clear-before-lookup sequence. It now loads the fields first. ComboItems is what those dialogs call. The comment matches CCombo: setItems clears the text only when the combo is not editable, and removeAll() is what always clears it. The test fake does the same. A read-only combo does not get a value back when that value is not in the new list. Fuzzy Match, XSD Validator, Zip File, and BaseTransformDialog.getFieldsFromPrevious are back to the previous code. They already kept the text. Table Exists, YAML Input, File Metadata, Get Files Rows Count, and Get XML Data still clear the selection on a successful refresh, because they call removeAll() and do not write the name back. Regex Eval does select the previous value when it is still in the list. I updated the PR description to match. Dynamic SQL Row and Execute SQL Row called removeAll() twice. LDAP Input wrote the search base back into the filter field. Both are fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
