bamaer commented on PR #9243: URL: https://github.com/apache/hop/pull/9243#issuecomment-6677638951
Thanks @mattcasters, the collapsed totals row reads a lot better than the per-copy list. I built this locally and ran `PipelineMetricsGrouperTest` and `PipelineMetricsTreeTest`; both pass. I haven't run it in the GUI yet. **Blocker** - **Parent speed total depends on the desktop's number format.** [PipelineMetricsGrouper.java:260-278](https://github.com/apache/hop/blob/86a2cccbd0034c8d7fe8dfdf651fdc60ca2aaea8/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/delegates/PipelineMetricsGrouper.java#L260-L278): `TransformStatus` formats speed with a `DecimalFormat` in the local format, but `parseSpeed` only strips `,`. With 4 copies at 12,345 rows/s, the parent row shows `49,380` on en-US, `49` on nl-BE/de-DE, and `-` on fr-FR. Parsing with `new DecimalFormat(SPEED_PATTERN).parse(...)` before the comma fallback gives 49,380 in all four, and the existing tests still pass. A test that formats the speed through `DecimalFormat` instead of a literal `" 1,000"` would cover it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
