bamaer commented on PR #9300: URL: https://github.com/apache/hop/pull/9300#issuecomment-6678175775
Thanks @hansva, LGTM. Built the PR and ran the `memgroupby` unit tests: all pass, and both new tests fail with the NPE from #9299 when the old `MemoryGroupBy.java` is put back. Also tried null as the first row, a single value among nulls, and `HOP_AGGREGATION_ALL_NULLS_ARE_ZERO=Y` on an all-null group (gives 0.0). All behave like Group by. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
