bamaer commented on PR #9402:
URL: https://github.com/apache/hop/pull/9402#issuecomment-6890753238

   Thanks @rmannibucau, both points are fixed. Slow rows are no longer lost at 
the end of input, and a stopped process that ignores SIGTERM is now 
force-killed before `processRow` returns. I checked both with scratch tests, 
one of them against a real `trap '' TERM` script.
   
   One small regression from the new commit:
   
   **Should fix: stopping Language Model Chat with queued jobs now logs 
errors.**
   After a stop, `finish()` returns at once because `awaitJobsUncapped()` exits 
when the transform is stopped. It then calls `facadeMap.clear()` while queued 
jobs are still in the executor, and those jobs fail on a null facade. With 
parallelism 1 and 5 queued rows, a stop now ends with 1 error. On `main` and on 
the previous commit it ended with 0.
   
   Suggested fix: remove `facadeMap.clear()` from `finish()` 
(`LanguageModelChat.java:88`). `dispose()` already clears it after waiting for 
the jobs. With that change the stop ends with 0 errors and 
`LanguageModelChatLifecycleTest` still passes.
   
   **What was verified:** unit tests in all five modules (117, all passing, 
checkstyle on), plus scratch tests for the slow drain, the forced kill and the 
stop with queued jobs. Integration tests were not run.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to