rmannibucau commented on PR #9402:
URL: https://github.com/apache/hop/pull/9402#issuecomment-6893402804

   Rebased onto current main (`947ecbe21e`); updated head is `3ae7eb3034`.
   
   Review follow-up:
   - Retained upstream synchronous Html2Text implementation and its existing 
tests; removed the superseded asynchronous test.
   - Kept LanguageModelChat facades alive until disposal so queued work after 
stop can still complete safely. Added a deterministic stop/queued-work 
regression test, verified red with the old cleanup and green with the fix.
   
   Validation on Java 21 / Maven 3.9.16:
   - 140 focused tests across languagemodelchat, detectlanguage, execprocess, 
html2text and stanfordnlp: no failures, errors or skips; formatting and 
Checkstyle passed.
   - Client assembly succeeded.
   - Ran `integration-tests/transforms/main-0127-html2text.hwf` through the 
assembled `hop-run.sh`: passed both golden datasets, including three transform 
copies.
   - `git diff --check` passed.
   - GitHub build and UI checks are green; GitHub reports MERGEABLE / CLEAN.
   
   Scope note: the live Ollama integration workflow was not run; stop/disposal 
ordering is covered by deterministic lifecycle regression tests rather than a 
live model service. An earlier broad local reactor test run encountered the 
unrelated existing SVG font-assumption test failure; the current GitHub build 
passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to