[
https://issues.apache.org/jira/browse/HTRACE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292560#comment-14292560
]
stack commented on HTRACE-88:
-----------------------------
Where is the query language described?
Field strings here are 'begin' and 'end' but in the JSON the fields are named
'b' and 'e'? How to reconcile? If I type in 'b' in this new query language, my
query fails?
A field is called 'sid' here but do we call it 'spanid' elsewhere?
For the query, we have 'le' rather than '<'. This stuff is passed in query
string? So < would be encoded '<' ... and le as le... is '<' more what'd be
expected as symbol for '<'.
Should we allow JSON that has names written out in full.... i.e. ' spanid' for
's', and 'begin' for 'b', etc.
66 const SPAN_ID_INDEX_PREFIX = 's'
67 const BEGIN_TIME_INDEX_PREFIX = 'b'
68 const END_TIME_INDEX_PREFIX = 'e'
69 const DURATION_INDEX_PREFIX = 'd'
70 const PARENT_ID_INDEX_PREFIX = 'p'
71 const INVALID_INDEX_PREFIX = 0
Good you added defines for the JSON fields.
Should be more tests for different query types?
Otherwise patch looks good.
> Add REST query API to htraced
> -----------------------------
>
> Key: HTRACE-88
> URL: https://issues.apache.org/jira/browse/HTRACE-88
> Project: HTrace
> Issue Type: New Feature
> Affects Versions: 3.2.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-88.001.patch
>
>
> Add a REST query API to htraced. This will allow the web UI to implement its
> search page.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
