[
https://issues.apache.org/jira/browse/HTRACE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294448#comment-14294448
]
Colin Patrick McCabe commented on HTRACE-88:
--------------------------------------------
bq. Where is the query language described?
Let me add some description and an example to {{query.go}}.
bq. For the query, we have 'le' rather than '<'. This stuff is passed in query
string? So < would be encoded '<' ... and le as le... is '<' more what'd be
expected as symbol for '<'.
I was a little bit gunshy of using '<' since it doesn't play nice with HTML,
XML, or URLs. If we ever wanted to pass these query strings in URL parameters
that would be a problem. Also, strictly speaking, it's <= rather than < (less
than or equal, not just less than)... so same number of characters?
bq. A field is called 'sid' here but do we call it 'spanid' elsewhere?
That's a good point. Let me call it "spanid" instead.
bq. Should we allow JSON that has names written out in full.... i.e. ' spanid'
for 's', and 'begin' for 'b', etc.
Right now we only allow query JSON that has names written out in full. The
"prefix" stuff is used internally in the datastore. Basically it's a byte
prefix that the datastore uses to make the leveldb key. We also use 'b' and
'e' in the span JSON itself, but that's because we're handling so many of those
guys that every byte counts. We can afford to be more expressive with queries
since there aren't going to be that many of them.
bq. Should be more tests for different query types?
Yeah, I do wish there were more unit tests, but I always wish that :) Let me
add one or two more for different queries.
> Add REST query API to htraced
> -----------------------------
>
> Key: HTRACE-88
> URL: https://issues.apache.org/jira/browse/HTRACE-88
> Project: HTrace
> Issue Type: New Feature
> Affects Versions: 3.2.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-88.001.patch
>
>
> Add a REST query API to htraced. This will allow the web UI to implement its
> search page.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
