[
https://issues.apache.org/jira/browse/HTRACE-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335591#comment-14335591
]
Colin Patrick McCabe commented on HTRACE-108:
---------------------------------------------
Great stuff!
{code}
75 query: function() {
76 var predicates = this.state.predicates.slice(0);
77 var lastSpanId = this.state.lastSpanId;
76
79 if (lastSpanId) {
80 predicates.push({
81 "op": "gt",
82 "field": "spanid",
83 "val": lastSpanId
84 });
85 }
{code}
Maybe add a little comment here explaining that we are adding a new predicate
which will be ANDed with the previous ones, in order to avoid returning the
same results as the ones on the previous page.
{code}
78 this.listSpansPaginator = new Backgrid.Extension.Paginator({
79 collection: this.collection,
80 // renderIndexedPageHandles: false,
81 // controls: {
82 // rewind: null,
83 // fastForward: null
84 // }
{code}
What's with the commented out stuff?
{code}
- <script src="lib/js/underscore-1.7.0.min.js"
type="text/javascript"></script>
- <script src="lib/js/backbone-1.1.2.min.js" type="text/javascript"></script>
- <script src="lib/js/backbone.paginator-2.0.2.min.js"
type="text/javascript"></script>
- <script src="lib/js/backgrid-0.3.5.min.js" type="text/javascript"></script>
+ <script src="lib/js/underscore-1.7.0.js" type="text/javascript"></script>
+ <script src="lib/js/backbone-1.1.2.js" type="text/javascript"></script>
+ <script src="lib/js/backbone.paginator-2.0.2.js"
type="text/javascript"></script>
+ <script src="lib/js/backgrid-0.3.5.js" type="text/javascript"></script>
{code}
What's the purpose of switching from the minimized versions to the regular
versions? Easier to debug? Should we just get rid of the minimized versions
for now?
> Search Page: Use server side pagination
> ---------------------------------------
>
> Key: HTRACE-108
> URL: https://issues.apache.org/jira/browse/HTRACE-108
> Project: HTrace
> Issue Type: Sub-task
> Reporter: Abraham Elmahrek
> Assignee: Abraham Elmahrek
> Attachments: HTRACE-108.0.patch
>
>
> '/query' API supports querying by span ID as a predicate which can act as a
> continuation token.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
