[
https://issues.apache.org/jira/browse/HTRACE-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379407#comment-14379407
]
Masatake Iwasaki commented on HTRACE-120:
-----------------------------------------
Thanks for working on this, [~mayang]. I reviewed 002.
---
{noformat}
- this.spansCollection.fetch();
+ // this.spansCollection.fetch();
{noformat}
Should this be removal rather than commenting out?
---
{noformat}
@@ -41,23 +42,38 @@ app.SearchControlsView = Backbone.Marionette.View.extend({
manager: this,
field: 'description'
}));
+
+
+
{noformat}
These blank lines seems to be accidentaly added.
---
{noformat}
+ app.routes.navigate('!/search?' + this.searchParams);
{noformat}
Should we update only URL by {{Backbone.history.navigate}}?
{noformat}
Backbone.history.navigate('!/search?' + this.searchParams);
{noformat}
---
{noformat}
+ this.spansCollection.fullCollection.reset();
+ this.spansCollection.setPredicates(predicates);
+ this.spansCollection.fetch({remove: false});
+ }
+ else {
+ this.spansCollection.fullCollection.reset();
+
this.spansCollection.setPredicates([{"op":"cn","field":"description","val":""}]);
+ this.spansCollection.fetch({remove: false});
+ }
{noformat}
I think we do not need to do fetch in setup.js.
> UI: Track search history via URL hash
> -------------------------------------
>
> Key: HTRACE-120
> URL: https://issues.apache.org/jira/browse/HTRACE-120
> Project: HTrace
> Issue Type: Improvement
> Reporter: Abraham Elmahrek
> Assignee: May Ang
> Labels: ui
> Attachments: HTRACE-120.001.patch, HTRACE-120.002.patch
>
>
> Currently, the search UI can search by description and various filters. It
> would be nice to track the state of the search (as well as the filters if
> possible) through the URL hash. This way, history is tracked and users can
> use the "back" button in their browser to recall previous searches.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
