[
https://issues.apache.org/jira/browse/HTRACE-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394082#comment-14394082
]
Masatake Iwasaki commented on HTRACE-120:
-----------------------------------------
Thanks for the update, [~mayang]. I have one more comment.
{noformat}
@@ -70,10 +86,13 @@ app.SearchControlsView = Backbone.Marionette.View.extend({
"search": function(e) {
this.predicates = _(this.searchFields).map(function(field) {
return field.getPredicate();
- }).filter(function(predicate) {
- return predicate.val;
});
{noformat}
Should we keep this filtering? Without this, {{query}} API returns 500 error if
there is search field having blank value.
> UI: Track search history via URL hash
> -------------------------------------
>
> Key: HTRACE-120
> URL: https://issues.apache.org/jira/browse/HTRACE-120
> Project: HTrace
> Issue Type: Improvement
> Reporter: Abraham Elmahrek
> Assignee: May Ang
> Labels: ui
> Attachments: HTRACE-120.001.patch, HTRACE-120.002.patch,
> HTRACE-120.003.patch, HTRACE-120.004.patch
>
>
> Currently, the search UI can search by description and various filters. It
> would be nice to track the state of the search (as well as the filters if
> possible) through the URL hash. This way, history is tracked and users can
> use the "back" button in their browser to recall previous searches.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
