[ 
https://issues.apache.org/jira/browse/HTRACE-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636103#comment-14636103
 ] 

Masatake Iwasaki commented on HTRACE-209:
-----------------------------------------

Thanks for the explanation, [~cmccabe]. Let me have some time to look into the 
patch tonight.


bq. I think htrace-hbase does something similar.

htrace-hbase uses traceId as rowkey and spanId as qualifier, though it should 
be overhauled to catch up with the new features such as multiple parent spans 
and Web-UI gadgets.


bq. Trace ID is also unnecessary-- you can deduce everything it is telling you 
just by looking up the parents yourself.

It is true after whole spans in trace are received but traceId is useful to 
store spans into HBase as it arrives (and Bigtable). Using traceId as rowkey 
keeps spans in same trace stored in same place. Also it may help to retain the 
origin of the span when some spans are lost and it is impossible to look up 
parent.


> Make span ID 128 bit to avoid collisions
> ----------------------------------------
>
>                 Key: HTRACE-209
>                 URL: https://issues.apache.org/jira/browse/HTRACE-209
>             Project: HTrace
>          Issue Type: Sub-task
>    Affects Versions: 4.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-209.001.patch, HTRACE-209.002.patch, 
> HTRACE-209.004.patch
>
>
> Make span ID 128 bit to avoid collisions in htrace 4.x



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to