[
https://issues.apache.org/jira/browse/HTRACE-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641061#comment-14641061
]
Colin Patrick McCabe commented on HTRACE-209:
---------------------------------------------
Thanks for taking a look.
bq. Both of git apply and patch have errors on many files. It seems not to be
just rebasing issue. Could you create new patch again? (htrace-core had few
errors and I succeeded to build and test by manually fixing rejected hunks.)
Sorry about that. I've been working on an internal branch, but some of the
subtasks are getting committed out of order. I'll rebase against master.
bq. Is it misleading using UUID format for what is not UUID? Even random based
UUID seems to be little bit different from random number.
Wikipedia says that "version 4" UUIDs can be "completely random."
https://en.wikipedia.org/wiki/Universally_unique_identifier ... Although
verison 4 UUIDs are specified to only use 122 bits rather than the full 128,
unlike how this patch works. I'm willing to consider some other textual format
for the ID, but the UUID format seemed fairly standard and easy to type. I
wonder if you guys have any ideas for alternate formats? [~stack], what do you
think?
bq. The patch effectively makes traceId and spanId tightly coupled. Because the
current TraceInfo has equivalent information with new SpanId, is it possible to
make the change backward compatible by leaving TraceInfo and
Trace#startSpan(String description, TraceInfo tinfo)?
There isn't really any way to make this change compatibly, since there are tons
of places in the code that assume that span ID is 64 bits. We have APIs
returning longs for span ID, and so forth. Anyway, HTrace 4.0 is an API
cleanup release, there are already many backwards-incompatible changes. I
don't think there is any reason to keep TraceInfo around. This is our chance
to clean up the API before HTrace goes into production in a lot of places and
changes become very difficult to make.
> Make span ID 128 bit to avoid collisions
> ----------------------------------------
>
> Key: HTRACE-209
> URL: https://issues.apache.org/jira/browse/HTRACE-209
> Project: HTrace
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-209.001.patch, HTRACE-209.002.patch,
> HTRACE-209.004.patch
>
>
> Make span ID 128 bit to avoid collisions in htrace 4.x
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
